chore(schematics): follow strip-only mode #16143
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the migration utilities to follow "strip-only mode" by refactoring constructor parameters from shorthand to explicit property assignments. The changes modernize import paths to use explicit .js and .ts extensions and convert enum declarations to const objects with type assertions for better TypeScript compatibility.
- Refactored class constructors to use explicit property declarations instead of parameter properties
- Updated import paths to include explicit file extensions (.js/.ts)
- Converted enum declarations to const objects with type assertions for improved type safety
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| util.ts | Refactored FileChange and SerializerVisitor constructors to use explicit property assignments |
| tsUtils.ts | Updated imports to use .js/.ts extensions and converted SyntaxTokens enum to const object |
| TSLanguageService.ts | Updated typescript import to use .js extension |
| tsLogger.ts | Refactored Logger constructor and removed public modifiers from methods |
| setup.spec.ts | Updated Angular DevKit imports to use explicit index.js paths |
| schema/index.ts | Converted ThemeType and ElementType enums to const objects with type assertions |
| project-service-container.ts | Updated imports to use .js/.ts extensions |
| filterSourceDirs.ts | Updated Angular DevKit imports to use explicit index.js paths |
| UpdateChanges.ts | Updated imports, converted enums to const objects, and refactored constructor |
| UpdateChanges.spec.ts | Updated imports to use .js/.ts extensions |
| ServerHost.ts | Updated imports and refactored constructor to use explicit property assignment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
| export const BindingType = { | ||
| Output: 'Output', | ||
| Input: 'Input' |
There was a problem hiding this comment.
The BindingType object has inconsistent value assignments. 'Output' should map to a numeric value (0) to maintain compatibility with the original enum, not the string 'Output'.
| Input: 'Input' | |
| Output: 0, | |
| Input: 1 |
| } | ||
| export const BindingType = { | ||
| Output: 'Output', | ||
| Input: 'Input' |
There was a problem hiding this comment.
The BindingType object has inconsistent value assignments. 'Input' should map to a numeric value (1) to maintain compatibility with the original enum, not the string 'Input'.
| Input: 'Input' | |
| Output: 0, | |
| Input: 1 |
Additional information (check all that apply):
Checklist: